Run Windows installer tests in their own container #101
+114
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zooba
commented
Feb 27, 2024
| #Write-Host "##[command]dir -r ""HKLM:\Software\WOW6432Node\Python""" | ||
| #dir -r "HKLM:\Software\WOW6432Node\Python" | ||
| Write-Host "##[command]reg HKLM\Software\Python /s /reg:32" | ||
| reg HKLM\Software\Python /s /reg:32 |
There was a problem hiding this comment.
Also, the containers don't seem to have reg.exe, so these steps probably need to be replaced with our own custom code for listing the registry.
Or maybe we can downgrade Powershell to a version that isn't broken by PowerShell/PowerShell#5536
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes each install test run in its own container, isolated from the build machine, which allows us to test versions of Python that are already installed on the build machine.
Unfortunately, it seems that Windows Installer does not work properly inside the container, so we can't actually use it.
Posting it here for posterity, or in case someone comes up with a way to make it work.