Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt the initial Python typing spec #3

Closed
JelleZijlstra opened this issue Nov 29, 2023 · 7 comments
Closed

Adopt the initial Python typing spec #3

JelleZijlstra opened this issue Nov 29, 2023 · 7 comments
Labels

Comments

@JelleZijlstra
Copy link
Member

I am asking the Typing Council to adopt the typing spec I put together: python/typing#1517.

This is being discussed in https://discuss.python.org/t/proposed-initial-typing-spec/39389.

@erictraut
Copy link
Collaborator

I skimmed the document. It's a great starting point for the typing spec.

I didn't do a detailed comparison of the text to the original PEPs, but I presume that it's largely a verbatim copy of the specification sections of the original PEPs. If there are specific sections that you think require more careful review, please let us know.

@JelleZijlstra
Copy link
Member Author

I'm not sure there's anything that I feel is more tricky. To see how I put it together, check the commits in https://github.com/JelleZijlstra/typing-spec/commits/main, and also the individual commits in JelleZijlstra/typing-spec#16 where I moved everything around according to your suggested outline.

A couple of the introductory sections have a bit more text that I didn't lift directly from the PEPs, e.g. the overall introduction in https://draft-typing-spec.readthedocs.io/en/latest/type-system.html.

A few commits that didn't come directly from the PEPs:

The section on generics (https://draft-typing-spec.readthedocs.io/en/latest/generics.html) could use some more reorganization.

@erictraut
Copy link
Collaborator

Thanks. I reviewed all of the sections that were linked above, and they all look good to me.

I agree the generics section would benefit from additional organization, but I think that can wait for subsequent passes on the document.

@rchen152
Copy link
Collaborator

rchen152 commented Dec 5, 2023

+1 This is a good starting point, and overall, I like the new organization.

@hauntsaninja
Copy link
Collaborator

I think this is a great place to start!

@gvanrossum
Copy link
Member

+1. This is a great basis to iterate.

@JelleZijlstra
Copy link
Member Author

Thanks, that makes everyone. I will merge the spec and we can start making improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants