You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems the current approach for managing config is with .get and .set methods.
I believe it would make sense to also implement __getitem__ and __setitem__ dunder methods in addition to this.
For example, the code example
config.set('number', 42)
config.get('number')
could also be written as
config["number"] = 42
config["number"]
Looking at the source, this should be a relatively small update to implement. If you think this would be acceptable, I am happy to add it myself and submit a PR.
The text was updated successfully, but these errors were encountered:
It seems the current approach for managing config is with
.get
and.set
methods.I believe it would make sense to also implement
__getitem__
and__setitem__
dunder methods in addition to this.For example, the code example
could also be written as
Looking at the source, this should be a relatively small update to implement. If you think this would be acceptable, I am happy to add it myself and submit a PR.
The text was updated successfully, but these errors were encountered: