Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A simple adaption to Jax #59

Open
zinccat opened this issue Oct 21, 2024 · 3 comments
Open

A simple adaption to Jax #59

zinccat opened this issue Oct 21, 2024 · 3 comments

Comments

@zinccat
Copy link
Contributor

zinccat commented Oct 21, 2024

Just done a bit of straightforward adaptation to Jax, performance is ~20% slower: https://github.com/zinccat/flaxattention
Thanks for the great project!
@Chillee
Copy link
Contributor

Chillee commented Oct 21, 2024

This is fun :) On a quick skim, I think the parts you haven't adopted yet are:

  1. block-sparsity
  2. autograd support
  3. "captured" buffers

@zinccat
Copy link
Contributor Author

zinccat commented Oct 21, 2024

yeah, I'm trying to work on autograd first

@Chillee
Copy link
Contributor

Chillee commented Oct 21, 2024

I think autograd won't be so bad, but I think "captured" buffers would be much more difficult to do in Jax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Chillee @zinccat