combine cat + reorder for combined indice into one pass #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D48058732 |
|
This pull request was exported from Phabricator. Differential Revision: D48058732 |
garroud
added a commit
to garroud/FBGEMM
that referenced
this pull request
Aug 11, 2023
Summary: Pull Request resolved: pytorch#1932 as title. combine cat + reorder into one pass for combined indice to avoid unncessary copy of cat_indices. Also added a micro benchmark for such case Differential Revision: D48058732 fbshipit-source-id: 1523f7862bd8bebae41b1dec8a3cee696cfd4aac
garroud
force-pushed
the
export-D48058732
branch
from
1ef861e to
dbc4bb4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48058732 |
garroud
added a commit
to garroud/FBGEMM
that referenced
this pull request
Aug 11, 2023
Summary: Pull Request resolved: pytorch#1932 as title. combine cat + reorder into one pass for combined indice to avoid unncessary copy of cat_indices. Also added a micro benchmark for such case Differential Revision: D48058732 fbshipit-source-id: 0e0fdfa6dc03dcf763210093ec3311998488be6e
garroud
force-pushed
the
export-D48058732
branch
from
dbc4bb4 to
e428619
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48058732 |
garroud
added a commit
to garroud/FBGEMM
that referenced
this pull request
Aug 11, 2023
Summary: Pull Request resolved: pytorch#1932 as title. combine cat + reorder into one pass for combined indice to avoid unncessary copy of cat_indices. Also added a micro benchmark for such case Differential Revision: D48058732 fbshipit-source-id: d4bd5b1acbc35f03180f46993ae68de7b0c1e8e8
garroud
force-pushed
the
export-D48058732
branch
from
e428619 to
80ab7a6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48058732 |
garroud
added a commit
to garroud/FBGEMM
that referenced
this pull request
Aug 17, 2023
Summary: Pull Request resolved: pytorch#1932 as title. combine cat + reorder into one pass for combined indice to avoid unncessary copy of cat_indices. Also added a micro benchmark for such case Differential Revision: D48058732 fbshipit-source-id: a5e69edd76452c35e659bb6baba5bb914c54b67b
garroud
force-pushed
the
export-D48058732
branch
from
80ab7a6 to
756ba9e
Compare
Summary: Pull Request resolved: pytorch#1932 as title. combine cat + reorder into one pass for combined indice to avoid unncessary copy of cat_indices. Also added a micro benchmark for such case Differential Revision: D48058732 fbshipit-source-id: 963bd0b7a438e12a2e6670b0f25a5c3917cbf9c8
|
This pull request was exported from Phabricator. Differential Revision: D48058732 |
garroud
force-pushed
the
export-D48058732
branch
from
756ba9e to
edb2042
Compare
|
This pull request has been merged in 016a27b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
as title. combine cat + reorder into one pass for combined indice to avoid unncessary copy of cat_indices.
Also added a micro benchmark for such case
Differential Revision: D48058732