Add psd method to torchaudio.functional #2227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwangjeff
reviewed
Feb 17, 2022
nateanl
force-pushed
the
refactor_mvdr_0
branch
from
482cedd
to
48399ae
Compare
nateanl
changed the title
nateanl
force-pushed
the
refactor_mvdr_0
branch
from
6f04a52
to
fd896a1
Compare
mthrok
reviewed
Feb 18, 2022
| @@ -617,6 +617,29 @@ def test_phase_vocoder(self): | |||
| )[..., None] | |||
| self._assert_consistency_complex(F.phase_vocoder, (tensor, rate, phase_advance)) | |||
|
|
|||
| def test_psd(self): | |||
| def func(specgram): | |||
There was a problem hiding this comment.
Is this helper function required?
IIRC, the reason why the helper function was introduced in other tests is that the helper method does not accept args and kwargs because scripted-function do not support them.
From that viewpoint, this helper function is not required.
There was a problem hiding this comment.
My experience is that if not using helper function, the arguments with default values need to be given explicitly. In that case, is it good to put all arguments in the inputs?
mthrok
approved these changes
Feb 25, 2022
| @@ -582,6 +583,35 @@ def test_rnnt_loss_costs_and_gradients_random_data_with_numpy_fp32(self): | |||
| ref_costs, ref_gradients = rnnt_utils.compute_with_numpy_transducer(data=data) | |||
| self._test_costs_and_gradients(data=data, ref_costs=ref_costs, ref_gradients=ref_gradients) | |||
|
|
|||
| def test_psd(self): | |||
|
@nateanl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
nateanl
force-pushed
the
refactor_mvdr_0
branch
from
b780ceb
to
380ad3c
Compare
|
@nateanl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
11 tasks
xiaohui-zhang
pushed a commit
to xiaohui-zhang/audio
that referenced
this pull request
May 4, 2022
Summary: This PR adds ``psd`` method to ``torchaudio.functional``. It computes the power spectral density (PSD) matrix of the complex-valued spectrum. The method also supports normalization of Time-Frequency mask. Pull Request resolved: pytorch#2227 Reviewed By: mthrok Differential Revision: D34473908 Pulled By: nateanl fbshipit-source-id: c1cfc584085d77881b35d41d76d39b26fca1dda9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
psdmethod totorchaudio.functional.It computes the power spectral density (PSD) matrix of the complex-valued spectrum.
The method also supports normalization of Time-Frequency mask.