Add an option to use Tanh instead of ReLU in RNNT joiner #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaohui-zhang
changed the title
hwangjeff
reviewed
Apr 5, 2022
hwangjeff
reviewed
Apr 6, 2022
hwangjeff
reviewed
Apr 6, 2022
hwangjeff
approved these changes
Apr 6, 2022
|
@xiaohui-zhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hey @xiaohui-zhang. |
xiaohui-zhang
added a commit
to xiaohui-zhang/audio
that referenced
this pull request
May 4, 2022
Summary: Add an option to use Tanh instead of ReLU in RNNT joiner, which enables better training performance sometimes. --- Pull Request resolved: pytorch#2319 Reviewed By: hwangjeff Differential Revision: D35422122 Pulled By: xiaohui-zhang fbshipit-source-id: c6a0f8b25936e47081110af046b57d0e8751f9a2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to use Tanh instead of ReLU in RNNT joiner, which enables better training performance sometimes.
Pull Request resolved: #2319
GitHub Author: xiaohui-zhang xiaohuizhang@fb.com