Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wavernn.py #2347

Closed
wants to merge 1 commit into from
Closed

Update wavernn.py #2347

wants to merge 1 commit into from

Conversation

bingcheng1998
Copy link
Contributor

fix false shape

@bingcheng1998
Update wavernn.py
1935387 
fix false shape
@facebook-github-bot
Copy link
Contributor

Hi @bingcheng1998!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

nateanl
nateanl approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@nateanl nateanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bingcheng1998, thanks for fixing it! Conformed that the fixed output shape is correct.

@nateanl
Copy link
Member

nateanl commented Apr 25, 2022

Could you sign the CLA Check? Then I can help merge this PR. Thanks.

@bingcheng1998
Copy link
Contributor Author

Thank you. I've signed it.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@nateanl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions
Copy link

Hey @nateanl.
You merged this PR, but labels were not properly added. Please add a primary and secondary label (See https://github.com/pytorch/audio/blob/main/.github/process_commit.py)

xiaohui-zhang pushed a commit to xiaohui-zhang/audio that referenced this pull request May 4, 2022
@bingcheng1998 @xiaohui-zhang
Update wavernn.py (pytorch#2347)
71b15cb 
Summary:
fix false shape

Pull Request resolved: pytorch#2347

Reviewed By: carolineechen

Differential Revision: D35921047

Pulled By: nateanl

fbshipit-source-id: 5b58820ee777920c68f13a15d80cd2bcc931af87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nateanl nateanl nateanl approved these changes

Assignees
No one assigned
Labels
CLA Signed improvement module: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bingcheng1998 @facebook-github-bot @nateanl