Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MVDR module #2383

Closed
wants to merge 2 commits into from
Closed

Refactor MVDR module #2383

wants to merge 2 commits into from

Conversation

nateanl
Copy link
Member

@nateanl nateanl commented May 11, 2022

  • Use apply_beamforming, rtf_evd, rtf_power, mvdr_weights_souden, mvdr_weights_rtf methods under torchaudio.functional to replace the class methods.
  • Refactor docstrings in PSD and MVDR.
  • Put _get_mvdr_vector outside of MVDR class as it doesn't call self methods inside.
  • Since MVDR uses einsum for matrix operations, packing and unpacking batches are not necessary. It can be tested by the batch_consistency_test. Removed it from the code.

@nateanl
Copy link
Member Author

nateanl commented May 11, 2022

@nateanl
Copy link
Member Author

nateanl commented May 11, 2022

since MVDR uses einsum for matrix operations, packing and unpacking batches are not necessary. It can be tested by the batch_consistency_test.

@mthrok
Copy link
Collaborator

mthrok commented May 12, 2022

since MVDR uses einsum for matrix operations, packing and unpacking batches are not necessary. It can be tested by the batch_consistency_test.

Can you update the PR description to include this?

@facebook-github-bot
Copy link
Contributor

@nateanl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants