[Cherry-picked 0.12] Update audio I/O tutorials #2385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
force-pushed
the
update-audio-io-tutorial
branch
from
306c62c
to
2d2bf4c
Compare
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mthrok
force-pushed
the
update-audio-io-tutorial
branch
from
2d2bf4c
to
b4329f4
Compare
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mthrok
force-pushed
the
update-audio-io-tutorial
branch
from
b4329f4
to
4e1af5e
Compare
nateanl
reviewed
May 25, 2022
| # >>> Source: https://pytorch-tutorial-assets.s3.amazonaws.com/steam-train-whistle-daniel_simon.mp3 | ||
| # >>> Fetched 8192 bytes. | ||
| # >>> AudioMetaData(sample_rate=44100, num_frames=0, num_channels=2, bits_per_sample=0, encoding=MP3) | ||
| # When passing a file-like object, ``info`` does not read |
There was a problem hiding this comment.
Suggested change
| # When passing a file-like object, ``info`` does not read | |
| # When passing a file-like object, ``info`` cannot access |
mthrok
force-pushed
the
update-audio-io-tutorial
branch
from
4e1af5e
to
dc1fba0
Compare
- Adopt `torchaudio.utils.download_asset` to simplify asset management. - Break down the first section about helper functions. - Use tempfile so that executing tutorial won't leave any artifacts on local file system.
mthrok
force-pushed
the
update-audio-io-tutorial
branch
from
dc1fba0
to
cfa98fb
Compare
hwangjeff
approved these changes
Jun 7, 2022
Co-authored-by: nateanl <zni@fb.com> Co-authored-by: hwangjeff <hwangjeff@users.noreply.github.com>
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hey @mthrok. |
mthrok
added a commit
that referenced
this pull request
Jun 7, 2022
Summary: - Adopt `torchaudio.utils.download_asset` to simplify asset management. - Break down the first section about helper functions. - Use tempfile so that executing tutorial won't leave any artifacts on local file system. Example: https://output.circle-artifacts.com/output/job/b11a0087-8bf9-4999-a74f-b53798eaa77f/artifacts/0/docs/tutorials/audio_io_tutorial.html Pull Request resolved: #2385 Reviewed By: hwangjeff Differential Revision: D36404399 Pulled By: mthrok fbshipit-source-id: 106af34e8ddd22a061aa12767b444b32aef07bad
mthrok
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torchaudio.utils.download_assetto simplify asset management.Example: https://output.circle-artifacts.com/output/job/b11a0087-8bf9-4999-a74f-b53798eaa77f/artifacts/0/docs/tutorials/audio_io_tutorial.html