Update audio resampling tutorial #2386
Conversation
mthrok
force-pushed
the
update-audio-resample-tutorial
branch
from
2b48b19
to
95f4fbb
Compare
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| # ------------------------------------------------------------------------------- | ||
| # Preparation of data and helper functions. | ||
| # ------------------------------------------------------------------------------- | ||
| # Firstly, we import the modules and define the helper functions. |
There was a problem hiding this comment.
| # Firstly, we import the modules and define the helper functions. | |
| # First, we import the modules and define the helper functions. |
| # | ||
| # Lowpass filter width | ||
| # ~~~~~~~~~~~~~~~~~~~~ | ||
| # 3.1. Lowpass filter width |
There was a problem hiding this comment.
Similar to my comment in data augmentations PR: I prefer subsections in indented form over subsection numbers. I think this organization is a bit harder to read and also places the same amount of emphasis on the subsections as the main sections
There was a problem hiding this comment.
This is intentional change. The previous way, one has to click these subsection so many times par tutorial, and the fact that state of the collapse/uncollapse does not persist across refreshing (also, from time to time, it renders wrong after refresh where it is supposed to be uncollapsed) is very bad UX. Also uncollapsing one subsection moves the button for uncollapsing the subsequent subsections. This is common UX issue across the documentation. (much worse on functional/transform page, considering the number of items listed there)
mthrok
force-pushed
the
update-audio-resample-tutorial
branch
2 times, most recently
from
7a4c218
to
b457af6
Compare
- Replace mis-use of plot_specgram with plot_sweep, and remove plot_specgram - Move `benchmark_resample` to later section - Add numbers to section title
mthrok
force-pushed
the
update-audio-resample-tutorial
branch
from
b457af6
to
4c61c7f
Compare
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hey @mthrok. |
benchmark_resampleto later sectionhttps://output.circle-artifacts.com/output/job/9f7af187-777d-4d75-840f-2630a36295b7/artifacts/0/docs/tutorials/audio_resampling_tutorial.html