Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FFmpeg-based I/O as fallback in sox_io backend #2419

Closed
wants to merge 1 commit into from
Closed

Use FFmpeg-based I/O as fallback in sox_io backend #2419

wants to merge 1 commit into from

Commits on Jun 1, 2022

  1. Use FFmpeg-based I/O as fallback in sox_io backend (pytorch#2419) 

    Summary:
This commit add fallback mechanism to `info` and `load` functions of sox_io backend.
If torchaudio is compiled to use FFmpeg, and runtime dependencies are properly loaded,
in case `info` and `load` fail, it fallback to FFmpeg-based implementation.

BC-breaking changes:
 - FFmpeg does not report the number of frames for MP3, this is because MP3 does not store the information of the number of frames. It can be estimated from the audio duration and sample rate, but it might be inaccurate, so we keep it 0.

Depends on
- pytorch#2416
- pytorch#2417
- pytorch#2418
- pytorch#2423
- pytorch#2427

Pull Request resolved: pytorch#2419

Reviewed By: carolineechen

Differential Revision: D36740306

Pulled By: mthrok

fbshipit-source-id: 071d9441019b7e76bd9a7f44ed236333ca406be9
    @mthrok @facebook-github-bot
    mthrok authored and facebook-github-bot committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    22f6c22 View commit details
    Browse the repository at this point in the history