Tweak StreamReader error messages and tests #2429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mthrok
commented
Jun 1, 2022
mthrok
commented
- Update error messages
- Update audio stream tests
* Update error messages * Update audio stream tests
mthrok
force-pushed
the
fix-error-messages
branch
from
aaa4d95
to
4295fee
Compare
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jun 1, 2022
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
carolineechen
approved these changes
Jun 1, 2022
nateanl
approved these changes
Jun 1, 2022
| @@ -360,6 +360,20 @@ def test_seek_negative(self): | |||
| s.seek(-1.0) | |||
|
|
|||
|
|
|||
| def _to_fltp(original): | |||
There was a problem hiding this comment.
can you add doc string here? This helps future maintainer understand what's the functionality of the method.
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hey @mthrok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.