Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special handling to filelike object mp3 #2478

Closed
wants to merge 1 commit into from
Closed

Commits on Jun 14, 2022

  1. Add special handling to filelike object mp3

    Loading and querying file-like object is not possible to use the fallback
    mechanism introduced in pytorch#2419 because file-like objects are not seekable.
    
    This commit add special case handling to mp3.
    
    For filelike object mp3 input, it was required to pass `format="mp3"`
    because libsox did not auto detect the format.
    
    With the transition of mp3 handling from libsox to ffmpeg, the logic
    is to let the ffmpeg handle it without waiting for libsox to fail,
    if the `format="mp3"`
    mthrok committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    81afcf4 View commit details
    Browse the repository at this point in the history