From 80f57fd74174b33f0f8ed76955cc55281481d1b2 Mon Sep 17 00:00:00 2001 From: atalman Date: Thu, 16 Feb 2023 07:27:51 -0800 Subject: [PATCH 1/6] Smoke Test RC cut --- .github/scripts/validate_binaries.sh | 10 ++++++++-- .github/workflows/validate-nightly-binaries.yml | 4 ++-- .github/workflows/validate-release-binaries.yml | 8 -------- 3 files changed, 10 insertions(+), 12 deletions(-) diff --git a/.github/scripts/validate_binaries.sh b/.github/scripts/validate_binaries.sh index f11cd43ab..8324df2e7 100755 --- a/.github/scripts/validate_binaries.sh +++ b/.github/scripts/validate_binaries.sh @@ -6,7 +6,10 @@ else if [[ ${MATRIX_PYTHON_VERSION} == '3.11' ]]; then conda create -y -n ${ENV_NAME} python=${MATRIX_PYTHON_VERSION} conda activate ${ENV_NAME} - eval $MATRIX_INSTALLATION + + # remove vision and audio + INSTALLATION=${MATRIX_INSTALLATION/"torchvision torchaudio"/""} + eval $INSTALLATION python ./test/smoke_test/smoke_test.py --package torchonly conda deactivate conda env remove -n ${ENV_NAME} @@ -26,7 +29,10 @@ else conda create -y -n ${ENV_NAME} python=${MATRIX_PYTHON_VERSION} numpy pillow conda activate ${ENV_NAME} + INSTALLATION=${MATRIX_INSTALLATION/"conda install"/"conda install -y"} + # remove vision and audio + INSTALLATION=${INSTALLATION/"torchvision torchaudio"/""} eval $INSTALLATION if [[ ${TARGET_OS} == 'linux' ]]; then @@ -35,7 +41,7 @@ else ${PWD}/check_binary.sh fi - python ./test/smoke_test/smoke_test.py + python ./test/smoke_test/smoke_test.py --package torchonly conda deactivate conda env remove -n ${ENV_NAME} fi diff --git a/.github/workflows/validate-nightly-binaries.yml b/.github/workflows/validate-nightly-binaries.yml index c252e0433..3ae05cc32 100644 --- a/.github/workflows/validate-nightly-binaries.yml +++ b/.github/workflows/validate-nightly-binaries.yml @@ -30,6 +30,6 @@ jobs: nightly: uses: ./.github/workflows/validate-binaries.yml with: - channel: nightly + channel: test os: all - limit-win-builds: enable + limit-win-builds: disable diff --git a/.github/workflows/validate-release-binaries.yml b/.github/workflows/validate-release-binaries.yml index c0e239d03..9549e1e33 100644 --- a/.github/workflows/validate-release-binaries.yml +++ b/.github/workflows/validate-release-binaries.yml @@ -17,14 +17,6 @@ on: - .github/workflows/validate-macos-binaries.yml - .github/workflows/validate-macos-arm64-binaries.yml - test/smoke_test/* - pull_request: - paths: - - .github/workflows/validate-release-binaries.yml - - .github/workflows/validate-linux-binaries.yml - - .github/workflows/validate-windows-binaries.yml - - .github/workflows/validate-macos-binaries.yml - - .github/workflows/validate-macos-arm64-binaries.yml - - test/smoke_test/* jobs: release: From b096bd70a83e1a7dbc49ac3b2db22612c5d541df Mon Sep 17 00:00:00 2001 From: atalman Date: Thu, 16 Feb 2023 09:35:34 -0800 Subject: [PATCH 2/6] Validate binaries 3.11 --- .github/scripts/validate_binaries.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/scripts/validate_binaries.sh b/.github/scripts/validate_binaries.sh index 8324df2e7..a70bd6b6c 100755 --- a/.github/scripts/validate_binaries.sh +++ b/.github/scripts/validate_binaries.sh @@ -9,6 +9,7 @@ else # remove vision and audio INSTALLATION=${MATRIX_INSTALLATION/"torchvision torchaudio"/""} + INSTALLATION=${INSTALLATION/"-c pytorch"/"-c malfet -c pytorch"} eval $INSTALLATION python ./test/smoke_test/smoke_test.py --package torchonly conda deactivate From 09834d0e0806c82b825c521d92b421db1d9a1469 Mon Sep 17 00:00:00 2001 From: atalman Date: Thu, 16 Feb 2023 12:16:28 -0800 Subject: [PATCH 3/6] test --- .github/scripts/validate_binaries.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/scripts/validate_binaries.sh b/.github/scripts/validate_binaries.sh index a70bd6b6c..0a15f191f 100755 --- a/.github/scripts/validate_binaries.sh +++ b/.github/scripts/validate_binaries.sh @@ -10,6 +10,7 @@ else # remove vision and audio INSTALLATION=${MATRIX_INSTALLATION/"torchvision torchaudio"/""} INSTALLATION=${INSTALLATION/"-c pytorch"/"-c malfet -c pytorch"} + INSTALLATION=${INSTALLATION/"conda install"/"conda install -y"} eval $INSTALLATION python ./test/smoke_test/smoke_test.py --package torchonly conda deactivate From 2c01e46d0b194f3acfcba8eb17b712bb34bf8935 Mon Sep 17 00:00:00 2001 From: atalman Date: Mon, 20 Feb 2023 08:04:28 -0800 Subject: [PATCH 4/6] Smoke test binaries --- .github/scripts/validate_binaries.sh | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/.github/scripts/validate_binaries.sh b/.github/scripts/validate_binaries.sh index 0a15f191f..e540ae0ae 100755 --- a/.github/scripts/validate_binaries.sh +++ b/.github/scripts/validate_binaries.sh @@ -7,12 +7,10 @@ else conda create -y -n ${ENV_NAME} python=${MATRIX_PYTHON_VERSION} conda activate ${ENV_NAME} - # remove vision and audio - INSTALLATION=${MATRIX_INSTALLATION/"torchvision torchaudio"/""} - INSTALLATION=${INSTALLATION/"-c pytorch"/"-c malfet -c pytorch"} + INSTALLATION=${MATRIX_INSTALLATION/"-c pytorch"/"-c malfet -c pytorch"} INSTALLATION=${INSTALLATION/"conda install"/"conda install -y"} eval $INSTALLATION - python ./test/smoke_test/smoke_test.py --package torchonly + python ./test/smoke_test/smoke_test.py conda deactivate conda env remove -n ${ENV_NAME} else @@ -31,10 +29,7 @@ else conda create -y -n ${ENV_NAME} python=${MATRIX_PYTHON_VERSION} numpy pillow conda activate ${ENV_NAME} - INSTALLATION=${MATRIX_INSTALLATION/"conda install"/"conda install -y"} - # remove vision and audio - INSTALLATION=${INSTALLATION/"torchvision torchaudio"/""} eval $INSTALLATION if [[ ${TARGET_OS} == 'linux' ]]; then @@ -43,7 +38,7 @@ else ${PWD}/check_binary.sh fi - python ./test/smoke_test/smoke_test.py --package torchonly + python ./test/smoke_test/smoke_test.py conda deactivate conda env remove -n ${ENV_NAME} fi From 668b78e382b4fb98f220fdfa72ece61e4f941829 Mon Sep 17 00:00:00 2001 From: atalman Date: Mon, 20 Feb 2023 08:41:52 -0800 Subject: [PATCH 5/6] Fix pytorch-cuda chan download --- .github/scripts/validate_binaries.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/scripts/validate_binaries.sh b/.github/scripts/validate_binaries.sh index e540ae0ae..cfe7c4486 100755 --- a/.github/scripts/validate_binaries.sh +++ b/.github/scripts/validate_binaries.sh @@ -8,7 +8,9 @@ else conda activate ${ENV_NAME} INSTALLATION=${MATRIX_INSTALLATION/"-c pytorch"/"-c malfet -c pytorch"} + INSTALLATION=${INSTALLATION/"pytorch-cuda"/"pytorch-${MATRIX_CHANNEL}::pytorch-cuda"} INSTALLATION=${INSTALLATION/"conda install"/"conda install -y"} + eval $INSTALLATION python ./test/smoke_test/smoke_test.py conda deactivate From b7ebaaf0d6c9204318917f0b5974b0168f6502ff Mon Sep 17 00:00:00 2001 From: atalman Date: Mon, 20 Feb 2023 09:06:29 -0800 Subject: [PATCH 6/6] Remove temp change --- .github/workflows/validate-nightly-binaries.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/validate-nightly-binaries.yml b/.github/workflows/validate-nightly-binaries.yml index 3ae05cc32..c252e0433 100644 --- a/.github/workflows/validate-nightly-binaries.yml +++ b/.github/workflows/validate-nightly-binaries.yml @@ -30,6 +30,6 @@ jobs: nightly: uses: ./.github/workflows/validate-binaries.yml with: - channel: test + channel: nightly os: all - limit-win-builds: disable + limit-win-builds: enable