Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aarch64] Pin ACl to v22.11 #1552

Closed
wants to merge 1 commit into from
Closed

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Sep 29, 2023

This switches ACL back to working configuration.

At a time of this PR:
#1370

This code was added in Compute Library v23.05 :

if 'v8a' in env['arch']:
        print("INFO: multi_isa armv8-a architecture build doesn't enable __ARM_FEATURE_FP16_VECTOR_ARITHMETIC. Use armv8.2-a or beyond to enable FP16 vector arithmetic support")
        env.Append(CXXFLAGS = ['-march=armv8-a']) # note: this will disable fp16 extension __ARM_FEATURE_FP16_VECTOR_ARITHMETIC

Ref:
ARM-software/ComputeLibrary@6c713f0#diff-d78c5c377c03dd251edc72cdb0ae7d9986fa08361eb392187218f8c670c0bc4eR311

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, those I've tried this one few weeks back and it did not work

This is why I've collected the backtrace in pytorch/pytorch#109312 to show that it comes from https://github.com/oneapi-src/oneDNN/blob/99c3fb44488922554696276dc88e8b6279eb662d/src/common/utils.cpp#L113

@snadampal
Copy link
Contributor

@malfet , it's crashing even without ACL. I have built the wheels with USE_MKLDNN=ON but USE_MKLDNN_ACL=OFF, and observed the crash. So, i think it's the onednn build we need to check.

@snadampal
Copy link
Contributor

@malfet , please don't revert the ACL version. Please check my comment on the original issue
pytorch/pytorch#109312 (comment)

@malfet
Copy link
Contributor

malfet commented Sep 29, 2023

@malfet , it's crashing even without ACL. I have built the wheels with USE_MKLDNN=ON but USE_MKLDNN_ACL=OFF, and observed the crash. So, i think it's the onednn build we need to check.

@snadampal sorry, I should have made it clear in the issue, that this is not an ACL problem, but rather a oneDNN one

@malfet
Copy link
Contributor

malfet commented Oct 6, 2023

No longer needed

@malfet malfet closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants