Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation workflow on aarch64 with conda 23.11.0 and GLIBC_2.25 #1645

Merged
merged 7 commits into from
Dec 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/validate-aarch64-linux-binaries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,5 +95,11 @@ jobs:
printf '%s\n' ${{ toJson(inputs.release-matrix) }} > release_matrix.json
eval "$(conda shell.bash hook)"

# Standart case: Validate binaries
# NB: The latest conda 23.11.0 pulls in some dependencies of conda-libmamba-solver that
# require GLIBC_2.25, which is not available in the current aarch64 image causing the
# subsequence git command to fail. Basically, they don't work with CentOS 7 which AML 2
# is based on https://github.com/ContinuumIO/anaconda-issues/issues/12822
unset LD_LIBRARY_PATH

# Standard case: Validate binaries
source ./.github/scripts/validate_binaries.sh
11 changes: 10 additions & 1 deletion test/smoke_test/smoke_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,16 @@ def smoke_test_modules():
if module["repo"]:
if not os.path.exists(f"{cwd}/{module['repo_name']}"):
print(f"Path does not exist: {cwd}/{module['repo_name']}")
subprocess.check_output(f"git clone --depth 1 {module['repo']}", stderr=subprocess.STDOUT, shell=True)
try:
subprocess.check_output(
f"git clone --depth 1 {module['repo']}",
stderr=subprocess.STDOUT,
shell=True,
)
except subprocess.CalledProcessError as exc:
raise RuntimeError(
f"Cloning {module['repo']} FAIL: {exc.returncode} Output: {exc.output}"
) from exc
try:
smoke_test_command = f"python3 {module['smoke_test']}"
if target_os == 'windows':
Expand Down