throw instead of segfault with invalid args in pybindings #5726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5726
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 7a42c03 with merge base 2dd88fb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63547425 |
larryliu0820
approved these changes
Sep 27, 2024
Summary: Pull Request resolved: pytorch#5726 Fixed some Error() call sites and added better checking on the method name Reviewed By: larryliu0820, dbort Differential Revision: D63547425
|
This pull request was exported from Phabricator. Differential Revision: D63547425 |
JacobSzwejbka
force-pushed
the
export-D63547425
branch
from
3c32cda
to
7a42c03
Compare
|
This pull request has been merged in 9720715. |
|
@pytorchbot cherry-pick --onto release/0.4 -c release |
Cherry picking #5726The cherry pick PR is at #6108 The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fixed some Error() call sites and added better checking on the method name
Reviewed By: larryliu0820
Differential Revision: D63547425
closes #5648