-
-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more options to create_supervised_trainer #1235
Comments
I would like to work on this. |
@apthagowda97 sure, please go ahead. I assign you to this issue |
@apthagowda97 any updates on this ? Anyway, do not hesitate to ask question if something is not clear about the issue. |
By going through issue #419 its best to add gradient clipping to |
@apthagowda97 I think it is better let's keep the same name and add the options. Such that there is one multi-option helper function. |
@apthagowda97 any updates on this issue ? |
Sorry I was busy from past few days. I ll try to finish it Asap. |
Cross-posted from #1589 We discussed this PR and related issue with the team and we think that we should explore a bit different approach. Helper method Probably, it would more helpful to provide public methods like:
and inside Basically, the idea is something like that : def get_training_step_1(a):
def training_step(e, b):
print(a, e, b)
return training_step
def get_training_step_2(a):
def training_step(e, b):
print(a, e, b, "with amp")
return training_step
def create_supervised_trainer(a, opt):
training_step = None
if opt == 1:
training_step = get_training_step_1(a)
elif opt == 2:
training_step = get_training_step_2(a)
e = Engine(training_step)
return e |
🚀 Feature
Idea is to add more options to
create_supervised_trainer
helper:create_supervised_trainer()
#419For Hacktoberfest/PyDataGlobal contributors, feel free to ask questions for details if any and say that you would like to tackle the issue.
Please, take a look at CONTRIBUTING guide.
The text was updated successfully, but these errors were encountered: