Skip to content
This repository has been archived by the owner on Jan 22, 2022. It is now read-only.

add annotations based on lint failures #66

Open
suo opened this issue Sep 2, 2021 · 0 comments
Open

add annotations based on lint failures #66

suo opened this issue Sep 2, 2021 · 0 comments

Comments

@suo
Copy link
Member

suo commented Sep 2, 2021

pytorch/pytorch#64449 removed the add_annotations workflow from the workflow_run trigger, because it causes flakiness (lots of artifact uploading/downloading) and noises up master CI. In its place, we have the lint workflow run the add_annotations action itself.

Sadly, this doesn't work for CI runs triggered by PRs from forked repos, because the GITHUB_TOKEN supplied to fork pull requests only has read permissions.

@seemethere suggested an elegant solution, which is to have probot handle all of this to sidestep the write permission issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant