[ONNX][TypePromo] Explicit type promotion pass #104064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
pytorch-bot
bot
added
the
release notes: onnx
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104064
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit ff924c3: NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
[ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jun 22, 2023
ghstack-source-id: 5dafa469aa5e04e44da1e049d480324ba08e0bc2 Pull Request resolved: #104064
…on "[ONNX][TypePromo] Explicit type promotion pass" [ghstack-poisoned]
[ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jun 27, 2023
ghstack-source-id: b6ecfb481d3efdfceb4e5744bfffa799d6ad4631 Pull Request resolved: #104064
[ghstack-poisoned]
BowenBao
commented
Jun 27, 2023
| @@ -556,7 +490,7 @@ | |||
| and sample.kwargs.get("padding") == 1, | |||
| reason="FIXME: After https://github.com/microsoft/onnxruntime/issues/15446 is fixed", | |||
| ), | |||
| xfail( | |||
| skip( | |||
There was a problem hiding this comment.
After type promotion this test starts to fail a few subtests with unexpected pass, which appears to be inconsistent with the tagged xfail reason.
There was a problem hiding this comment.
Actually more likely due to the bumping onnxscript version in this PR, so unrelated to type promotion. The inconsistency concern still holds.
…multiple ops on "[ONNX][TypePromo] Explicit type promotion pass" This PR adds the `ExplicitTypePromotionPass` that does an fx graph to fx graph transformation explicitly adding cast nodes into the graph to emulate the PyTorch type promotion behavior. Full design doc and discussion at https://microsoft-my.sharepoint.com/:w:/p/bowbao/Edj2lF1oi0JIitT_3ntyuqkBo6ll7N6NJDmavM0lp_KkEA?e=OElyjR [ghstack-poisoned]
BowenBao
commented
Jun 27, 2023
BowenBao
requested review from
jeffdaily,
abock and
thiagocrepaldi
as code owners
|
I will update new diagnostic rule id prior to merging. |
titaiwangms
reviewed
Jun 29, 2023
justinchuby
reviewed
Jun 29, 2023
justinchuby
reviewed
Jun 29, 2023
justinchuby
reviewed
Jun 29, 2023
justinchuby
reviewed
Jun 29, 2023
…romotion pass" This PR adds the `ExplicitTypePromotionPass` that does an fx graph to fx graph transformation explicitly adding cast nodes into the graph to emulate the PyTorch type promotion behavior. Full design doc and discussion at https://microsoft-my.sharepoint.com/:w:/p/bowbao/Edj2lF1oi0JIitT_3ntyuqkBo6ll7N6NJDmavM0lp_KkEA?e=OElyjR [ghstack-poisoned]
BowenBao
commented
Jun 30, 2023
This PR adds the `ExplicitTypePromotionPass` that does an fx graph to fx graph transformation explicitly adding cast nodes into the graph to emulate the PyTorch type promotion behavior. Full design doc and discussion at https://microsoft-my.sharepoint.com/:w:/p/bowbao/Edj2lF1oi0JIitT_3ntyuqkBo6ll7N6NJDmavM0lp_KkEA?e=OElyjR [ghstack-poisoned]
titaiwangms
approved these changes
Jul 3, 2023
justinchuby
reviewed
Jul 3, 2023
justinchuby
reviewed
Jul 3, 2023
justinchuby
reviewed
Jul 3, 2023
justinchuby
approved these changes
Jul 6, 2023
This PR adds the `ExplicitTypePromotionPass` that does an fx graph to fx graph transformation explicitly adding cast nodes into the graph to emulate the PyTorch type promotion behavior. Full design doc and discussion at https://microsoft-my.sharepoint.com/:w:/p/bowbao/Edj2lF1oi0JIitT_3ntyuqkBo6ll7N6NJDmavM0lp_KkEA?e=OElyjR [ghstack-poisoned]
…Explicit type promotion pass" This PR adds the `ExplicitTypePromotionPass` that does an fx graph to fx graph transformation explicitly adding cast nodes into the graph to emulate the PyTorch type promotion behavior. Full design doc and discussion at https://microsoft-my.sharepoint.com/:w:/p/bowbao/Edj2lF1oi0JIitT_3ntyuqkBo6ll7N6NJDmavM0lp_KkEA?e=OElyjR [ghstack-poisoned]
|
@pytorchbot merge -f "unrelated cudnn failure" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
_run_node_and_set_meta#104720This PR adds the
ExplicitTypePromotionPassthat does an fx graph to fx graph transformationexplicitly adding cast nodes into the graph to emulate the PyTorch type promotion behavior.
Full design doc and discussion at https://microsoft-my.sharepoint.com/:w:/p/bowbao/Edj2lF1oi0JIitT_3ntyuqkBo6ll7N6NJDmavM0lp_KkEA?e=OElyjR