[FSDP][7/N] Add warning about frozen params #104967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Jul 11, 2023
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104967
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit a1c151e: NEW FAILURE - The following job has failed:
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (sharded)
awgu
added
release notes: distributed (fsdp)
[ghstack-poisoned]
awgu
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
kwen2501,
wanchaol,
fegin,
fduwjj,
kiukchung and
d4l3k
as code owners
[ghstack-poisoned]
awgu
commented
Jul 11, 2023
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Jul 11, 2023
ghstack-source-id: 1831d65cb9d573ff26fa9d71e63807b051ad97c8 Pull Request resolved: pytorch#104967
[ghstack-poisoned]
[ghstack-poisoned]
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Aug 2, 2023
ghstack-source-id: 4a472d3c230cfd6ecac32231989aeacfbc47ceee Pull Request resolved: pytorch#104967
[ghstack-poisoned]
|
Failure looks unrelated: linux-bionic-py3_8-clang8-xla / test (xla, 1, 1, linux.12xlarge) |
|
@pytorchbot merge -f "unrelated failures" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 2, 2023
Pull Request resolved: #104999 Approved by: https://github.com/rohan-varma ghstack dependencies: #104427, #104967
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 3, 2023
…104969) This does some code organization improvement. - It renames `_FSDPPolicy` to `_Policy` to show that it is not only for FSDP but for any module-level API. - It formalizes the contract that such a policy should return something like `target_module_to_kwargs: Dict[nn.Module, Dict[str, Any]]` that maps each module to wrap to its kwargs. It does so by requiring a `_run_policy` abstract method (this time private since users do not need to care about it). Then, our auto wrapping can just call `_run_policy()` to generate the dict and do any validation or post-processing. This PR is technically BC-breaking because it removes the public `ModuleWrapPolicy.policy`. However, I do not think anyone was using that anyway, so this is a pretty safe breakage. Pull Request resolved: #104969 Approved by: https://github.com/rohan-varma ghstack dependencies: #104427, #104967, #104999
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 3, 2023
This PR adds a new `CustomPolicy` that acts like the existing `lambda_auto_wrap_policy` except it (1) leverages the new auto wrapping infrastructure and (2) allows overriding FSDP kwargs for particular instances. (1) gives it access to the validation checks (like for frozen parameters), and (2) makes it as expressive as manual wrapping. This should allow us to effectively deprecate manual wrapping if desired.
The API is as follows:
```
def lambda_fn(module: nn.Module) -> Union[bool, Dict[str, Any]]:
...
policy = CustomPolicy(lambda_fn)
```
The `lambda_fn` can return:
- `False` or `{}` to indicate no wrapping
- `True` to indicate wrapping while inheriting the root's FSDP kwargs
- Non-empty `dict` to indicate wrapping while overriding the specified FSDP kwargs and inheriting the rest from the root
---
After this PR, the follow-up work items for auto wrapping are:
1. Add shared parameter validation
2. (Longer-term / exploratory) Add a policy that provides a reasonable auto wrapping with "minimal" user input
Pull Request resolved: #104986
Approved by: https://github.com/ezyang
ghstack dependencies: #104427, #104967, #104999, #104969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
CustomPolicy#104986_FSDPPolicy.policywith_Policy._run_policy#104969ModuleWrapPolicyto takeIterable#104999ModuleWrapPolicy#104427