Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdamW] Fix complex x amsgrad support #104990

Closed
wants to merge 4 commits into from

Conversation

janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Jul 11, 2023

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 11, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104990

Note: Links to docs will display an error until the docs builds have been completed.

✅ 3 Unrelated Failures

As of commit 3162cbc:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: optimizer Relating to optimizers, torch.optim label Jul 11, 2023
janeyx99 added a commit that referenced this pull request Jul 11, 2023
ghstack-source-id: 4d851afdcb5d29c0a81ccd415794225207605e3f
Pull Request resolved: #104990
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho good catch, thanks!

janeyx99 added a commit that referenced this pull request Jul 11, 2023
ghstack-source-id: 49118ef097f17dc86a76b61c7f3315c2fe42873c
Pull Request resolved: #104990
torch/optim/adamw.py Outdated Show resolved Hide resolved
torch/optim/adamw.py Outdated Show resolved Hide resolved
janeyx99 added a commit that referenced this pull request Jul 21, 2023
ghstack-source-id: 0982e85655000e87b17926e652c3fe44a5b42983
Pull Request resolved: #104990
@janeyx99
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 21, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@janeyx99 janeyx99 changed the title [foreach][AdamW] Fix complex x amsgrad support [AdamW] Fix complex x amsgrad support Jul 21, 2023
@facebook-github-bot facebook-github-bot deleted the gh/janeyx99/65/head branch July 25, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: optimizer Relating to optimizers, torch.optim
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants