Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Make unsupported node analysis result deterministic #105231

Closed
wants to merge 1 commit into from
Closed

[ONNX] Make unsupported node analysis result deterministic #105231

wants to merge 1 commit into from

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Jul 14, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

Replace Set with Dict for node.target to keep insertion order.

Fixes #105200

@BowenBao
[ONNX] Make unsupported node analysis result deterministic
a50a775 
Replace `Set` with `Dict` for node.target to keep insertion order.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 14, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105231

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit a50a775:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added release notes: onnx torch.onnx related changes that should show up in the release notes labels Jul 14, 2023
BowenBao added a commit that referenced this pull request Jul 14, 2023
@BowenBao
[ONNX] Make unsupported node analysis result deterministic
98c7874 
Replace `Set` with `Dict` for node.target to keep insertion order.

ghstack-source-id: 761f821f712be56b64cd7a4531c3d903471d803b
Pull Request resolved: #105231
@BowenBao BowenBao added the topic: improvements topic category label Jul 14, 2023
@BowenBao BowenBao marked this pull request as ready for review July 14, 2023 20:15
thiagocrepaldi
thiagocrepaldi approved these changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@thiagocrepaldi thiagocrepaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not a list? searching a list is linear, which is not great. But that pass runs once, so this might be fine.

Using dict wastes memory with None entries for each key. In terms of clarity, it is odd to have a dict which only the key is useful.

@BowenBao
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 14, 2023
@BowenBao
Copy link
Collaborator Author

Afaik this is the idiomatic way if you want an insertion_ordered_set in python. Please let me know if there are better options.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/264/head branch July 18, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagocrepaldi thiagocrepaldi thiagocrepaldi approved these changes

@abock abock Awaiting requested review from abock

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: improvements topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BowenBao @pytorchmergebot @thiagocrepaldi @pytorchbot