[ONNX] Introduce 'diagnostics' to 'dynamo_export' api #99668
Closed
+191
−181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99668
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit e857b37: NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
release notes: onnx
…ort' api" Summary * Introduce `DiagnosticContext` to `torch.onnx.dynamo_export`. * Remove `DiagnosticEngine` in preparations to update 'diagnostics' in `dynamo_export` to drop dependencies on global diagnostic context. No plans to update `torch.onnx.export` diagnostics. Next steps * Separate `torch.onnx.export` diagnostics and `torch.onnx.dynamo_export` diagnostics. * Drop dependencies on global diagnostic context. * Replace 'print's with 'logger.log'. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Apr 20, 2023
ghstack-source-id: 75cfe1c6e1e4265c01d965003d52079cebb01cfd Pull Request resolved: #99668
Summary * Introduce `DiagnosticContext` to `torch.onnx.dynamo_export`. * Remove `DiagnosticEngine` in preparations to update 'diagnostics' in `dynamo_export` to drop dependencies on global diagnostic context. No plans to update `torch.onnx.export` diagnostics. Next steps * Separate `torch.onnx.export` diagnostics and `torch.onnx.dynamo_export` diagnostics. * Drop dependencies on global diagnostic context. * Replace 'print's with 'logger.log'. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Apr 21, 2023
ghstack-source-id: a74cd67c2ba0a2ceaf762a7be5ed35735edbcebc Pull Request resolved: #99668
…ynamo_export' api" Summary * Introduce `DiagnosticContext` to `torch.onnx.dynamo_export`. * Remove `DiagnosticEngine` in preparations to update 'diagnostics' in `dynamo_export` to drop dependencies on global diagnostic context. No plans to update `torch.onnx.export` diagnostics. Next steps * Separate `torch.onnx.export` diagnostics and `torch.onnx.dynamo_export` diagnostics. * Drop dependencies on global diagnostic context. * Replace 'print's with 'logger.log'. [ghstack-poisoned]
Summary * Introduce `DiagnosticContext` to `torch.onnx.dynamo_export`. * Remove `DiagnosticEngine` in preparations to update 'diagnostics' in `dynamo_export` to drop dependencies on global diagnostic context. No plans to update `torch.onnx.export` diagnostics. Next steps * Separate `torch.onnx.export` diagnostics and `torch.onnx.dynamo_export` diagnostics. * Drop dependencies on global diagnostic context. * Replace 'print's with 'logger.log'. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Apr 21, 2023
ghstack-source-id: 0f244844f8dc6d0f623931e95c3910830a121210 Pull Request resolved: #99668
BowenBao
added
module: onnx
Summary * Introduce `DiagnosticContext` to `torch.onnx.dynamo_export`. * Remove `DiagnosticEngine` in preparations to update 'diagnostics' in `dynamo_export` to drop dependencies on global diagnostic context. No plans to update `torch.onnx.export` diagnostics. Next steps * Separate `torch.onnx.export` diagnostics and `torch.onnx.dynamo_export` diagnostics. * Drop dependencies on global diagnostic context. * Replace 'print's with 'logger.log'. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Apr 24, 2023
ghstack-source-id: 0e8851dcd86cb97f6ab1bc8ce35bb078123412f4 Pull Request resolved: #99668
Summary * Introduce `DiagnosticContext` to `torch.onnx.dynamo_export`. * Remove `DiagnosticEngine` in preparations to update 'diagnostics' in `dynamo_export` to drop dependencies on global diagnostic context. No plans to update `torch.onnx.export` diagnostics. Next steps * Separate `torch.onnx.export` diagnostics and `torch.onnx.dynamo_export` diagnostics. * Drop dependencies on global diagnostic context. * Replace 'print's with 'logger.log'. [ghstack-poisoned]
Summary * Introduce `DiagnosticContext` to `torch.onnx.dynamo_export`. * Remove `DiagnosticEngine` in preparations to update 'diagnostics' in `dynamo_export` to drop dependencies on global diagnostic context. No plans to update `torch.onnx.export` diagnostics. Next steps * Separate `torch.onnx.export` diagnostics and `torch.onnx.dynamo_export` diagnostics. * Drop dependencies on global diagnostic context. * Replace 'print's with 'logger.log'. [ghstack-poisoned]
Summary * Introduce `DiagnosticContext` to `torch.onnx.dynamo_export`. * Remove `DiagnosticEngine` in preparations to update 'diagnostics' in `dynamo_export` to drop dependencies on global diagnostic context. No plans to update `torch.onnx.export` diagnostics. Next steps * Separate `torch.onnx.export` diagnostics and `torch.onnx.dynamo_export` diagnostics. * Drop dependencies on global diagnostic context. * Replace 'print's with 'logger.log'. [ghstack-poisoned]
Summary * Introduce `DiagnosticContext` to `torch.onnx.dynamo_export`. * Remove `DiagnosticEngine` in preparations to update 'diagnostics' in `dynamo_export` to drop dependencies on global diagnostic context. No plans to update `torch.onnx.export` diagnostics. Next steps * Separate `torch.onnx.export` diagnostics and `torch.onnx.dynamo_export` diagnostics. * Drop dependencies on global diagnostic context. * Replace 'print's with 'logger.log'. [ghstack-poisoned]
Summary * Introduce `DiagnosticContext` to `torch.onnx.dynamo_export`. * Remove `DiagnosticEngine` in preparations to update 'diagnostics' in `dynamo_export` to drop dependencies on global diagnostic context. No plans to update `torch.onnx.export` diagnostics. Next steps * Separate `torch.onnx.export` diagnostics and `torch.onnx.dynamo_export` diagnostics. * Drop dependencies on global diagnostic context. * Replace 'print's with 'logger.log'. [ghstack-poisoned]
justinchuby
approved these changes
Apr 28, 2023
| @@ -193,7 +197,7 @@ def __enter__(self): | |||
| return self | |||
|
|
|||
| def __exit__(self, exc_type, exc_val, exc_tb): | |||
| return True | |||
| return None | |||
There was a problem hiding this comment.
What does this change? Just for my learning
There was a problem hiding this comment.
Returning True will suppress the exception. None will allow it to propagate.
abock
approved these changes
Apr 28, 2023
Summary * Introduce `DiagnosticContext` to `torch.onnx.dynamo_export`. * Remove `DiagnosticEngine` in preparations to update 'diagnostics' in `dynamo_export` to drop dependencies on global diagnostic context. No plans to update `torch.onnx.export` diagnostics. Next steps * Separate `torch.onnx.export` diagnostics and `torch.onnx.dynamo_export` diagnostics. * Drop dependencies on global diagnostic context. #100219 * Replace 'print's with 'logger.log'. [ghstack-poisoned]
Summary * Introduce `DiagnosticContext` to `torch.onnx.dynamo_export`. * Remove `DiagnosticEngine` in preparations to update 'diagnostics' in `dynamo_export` to drop dependencies on global diagnostic context. No plans to update `torch.onnx.export` diagnostics. Next steps * Separate `torch.onnx.export` diagnostics and `torch.onnx.dynamo_export` diagnostics. * Drop dependencies on global diagnostic context. #100219 * Replace 'print's with 'logger.log'. [ghstack-poisoned]
valentinandrei
pushed a commit
to valentinandrei/pytorch
that referenced
this pull request
May 2, 2023
Summary * Introduce `DiagnosticContext` to `torch.onnx.dynamo_export`. * Remove `DiagnosticEngine` in preparations to update 'diagnostics' in `dynamo_export` to drop dependencies on global diagnostic context. No plans to update `torch.onnx.export` diagnostics. Next steps * Separate `torch.onnx.export` diagnostics and `torch.onnx.dynamo_export` diagnostics. * Drop dependencies on global diagnostic context. pytorch#100219 * Replace 'print's with 'logger.log'. Pull Request resolved: pytorch#99668 Approved by: https://github.com/justinchuby, https://github.com/abock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary
DiagnosticContexttotorch.onnx.dynamo_export.DiagnosticEnginein preparations to update 'diagnostics' indynamo_exportto drop dependencies on global diagnostic context. No plans to updatetorch.onnx.exportdiagnostics.Next steps
torch.onnx.exportdiagnostics andtorch.onnx.dynamo_exportdiagnostics.