Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a legacy mode for metrics #2795

Closed
Tracked by #1492
namannandan opened this issue Nov 15, 2023 · 0 comments · Fixed by #2816
Closed
Tracked by #1492

Add support for a legacy mode for metrics #2795

namannandan opened this issue Nov 15, 2023 · 0 comments · Fixed by #2816
Assignees

Comments

@namannandan
Copy link
Collaborator

🚀 The feature

Enable backwards compatibility for metrics behavior in versions <=0.8.0 by adding support for a new metrics mode: legacy

Motivation, pitch

In versions <=0.8.0:

  • ts_inference_requests_total, ts_inference_latency_microseconds and ts_queue_latency_microseconds are only available via the metrics API endpoint in prometheus format.
  • All other metrics are only logged to ts_metrics.log and model_metrics.log

In versions >0.8.0:

  • Based on metrics_mode configuration, all metrics are either logged to ts_metrics.log & model_metrics.log or they are all made available via the metrics API endpoint in prometheus format.

Behavior of legacy metrics mode:

  • ts_inference_requests_total, ts_inference_latency_microseconds and ts_queue_latency_microseconds are only available via the metrics API endpoint in prometheus format.
  • All other metrics inclusive of auto detected backend metrics are only logged to ts_metrics.log and model_metrics.log

Alternatives

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant