Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add compiled RMSNorm into the norm config #374

Closed
tianyu-l opened this issue May 30, 2024 · 1 comment
Closed

add compiled RMSNorm into the norm config #374

tianyu-l opened this issue May 30, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@tianyu-l
Copy link
Contributor

We should support compiled RMSNorm in the official release, instead of / in additional to using fused RMSNorm triton kernel. We can switch to CUDA kernel when it is ready in core (pytorch/pytorch#121364 (comment)).
@tianyu-l tianyu-l added the enhancement New feature or request label May 30, 2024
@tianyu-l
Copy link
Contributor Author

addressed in #442

@awgu awgu closed this as completed Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@awgu @tianyu-l