Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty prepend/append tags in PromptTemplate #1565

Closed
RdoubleA opened this issue Sep 12, 2024 · 1 comment
Closed

Handle empty prepend/append tags in PromptTemplate #1565

RdoubleA opened this issue Sep 12, 2024 · 1 comment
Labels
better engineering Tasks which help improve eng productivity e.g. building tools, cleaning up code, writing docs community help wanted We would love the community's help completing this issue

Comments

@RdoubleA
Copy link
Contributor

We currently assume the prepend/append tags in the prompt template are a string or an empty string. We should add more flexibility here to ignore the tag if its empty or None:

torchtune/torchtune/data/_prompt_templates.py

Line 111 in 01619ce

content = (

@RdoubleA RdoubleA added community help wanted We would love the community's help completing this issue better engineering Tasks which help improve eng productivity e.g. building tools, cleaning up code, writing docs labels Sep 12, 2024
@krammnic
Copy link
Contributor

Really minor fix. Check for None and change it to empty string should be fine. Will open PR

@krammnic krammnic mentioned this issue Oct 13, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
better engineering Tasks which help improve eng productivity e.g. building tools, cleaning up code, writing docs community help wanted We would love the community's help completing this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RdoubleA @krammnic