Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lora dropout is never applied #996

Closed
Optimox opened this issue May 17, 2024 · 1 comment
Closed

Lora dropout is never applied #996

Optimox opened this issue May 17, 2024 · 1 comment

Comments

@Optimox
Copy link
Contributor

Optimox commented May 17, 2024

If I am not mistaken, I don't think that the lora_dropout argument has any impact on the lora models since it's never passed through attention blocks nor the last mlp.

Please see #995 for my proposed fix.
@Optimox Optimox mentioned this issue May 17, 2024
Merged
11 tasks
@ebsmothers
Copy link
Contributor

Thanks @Optimox this is a great catch. Reviewing the PR now

@Optimox Optimox closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Optimox @ebsmothers