-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utils refactor clean-up #1515
utils refactor clean-up #1515
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1515
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0b586b1 with merge base 31a95a9 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1515 +/- ##
===========================================
+ Coverage 27.10% 72.88% +45.77%
===========================================
Files 284 284
Lines 13813 13810 -3
===========================================
+ Hits 3744 10065 +6321
+ Misses 10069 3745 -6324 ☔ View full report in Codecov by Sentry. |
Context
What is the purpose of this PR? Is it to
Few follow-up items after #1421 was completed. Some helpers were in the wrong locatino to avoid circular dependencies. We moved those back and remove some pesky dependencies between modules that pollute our dependency graph.
log_config
, do it in distribtued recipes instead._get_prompt_template
todata/
soconfig/
does not depend on any other directory other thanutils/
deprecated
fromdata/
toutils/
, a more appropriate location.Changelog
What are the changes made in this PR?
Test plan
Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.)
pre-commit install
)pytest tests
pytest tests -m integration_test
UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Example of docstring:
torchtune/torchtune/modules/vision_transformer.py
Line 285 in 6a7951f
Example in our docs: https://pytorch.org/torchtune/main/tutorials/qat_finetune.html#applying-qat-to-llama3-models