Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils refactor clean-up #1515

Merged
merged 5 commits into from
Sep 6, 2024
Merged

utils refactor clean-up #1515

merged 5 commits into from
Sep 6, 2024

Conversation

RdoubleA
Copy link
Contributor

@RdoubleA RdoubleA commented Sep 6, 2024

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

Few follow-up items after #1421 was completed. Some helpers were in the wrong locatino to avoid circular dependencies. We moved those back and remove some pesky dependencies between modules that pollute our dependency graph.

  • Removes the config <> training dependency. config should not depend on anything in training, only recipes should depend on training. Instead of checking for rank zero without log_config, do it in distribtued recipes instead.
  • Moves _get_prompt_template to data/ so config/ does not depend on any other directory other than utils/
  • Moves deprecated from data/ to utils/, a more appropriate location.

Changelog

What are the changes made in this PR?

Test plan

Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.)

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Example of docstring:


Example in our docs: https://pytorch.org/torchtune/main/tutorials/qat_finetune.html#applying-qat-to-llama3-models

  • I did not change any public API;
  • I have added an example to docs or docstrings;

Copy link

pytorch-bot bot commented Sep 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1515

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0b586b1 with merge base 31a95a9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 6, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 72.88%. Comparing base (277fbf8) to head (1aafd6b).

Files with missing lines Patch % Lines
recipes/full_finetune_distributed.py 0.00% 3 Missing ⚠️
recipes/lora_dpo_distributed.py 0.00% 3 Missing ⚠️
recipes/lora_finetune_distributed.py 0.00% 3 Missing ⚠️
recipes/qat_distributed.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1515       +/-   ##
===========================================
+ Coverage   27.10%   72.88%   +45.77%     
===========================================
  Files         284      284               
  Lines       13813    13810        -3     
===========================================
+ Hits         3744    10065     +6321     
+ Misses      10069     3745     -6324     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RdoubleA RdoubleA changed the title Log config on rank zero from recipes utils refactor clean-up Sep 6, 2024
felipemello1
felipemello1 previously approved these changes Sep 6, 2024
@felipemello1 felipemello1 dismissed their stale review September 6, 2024 21:11

changes still ongonig

@RdoubleA RdoubleA merged commit 8d2b46c into pytorch:main Sep 6, 2024
17 checks passed
@RdoubleA RdoubleA deleted the log_config branch September 6, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants