Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading call of 'iter' in the 'WrappedDataLoader' #1757

Closed
sadra-barikbin opened this issue Dec 6, 2021 · 2 comments · Fixed by #2375
Closed

Misleading call of 'iter' in the 'WrappedDataLoader' #1757

sadra-barikbin opened this issue Dec 6, 2021 · 2 comments · Fixed by #2375
Assignees
@HemanthSai7
Labels
docathon-h1-2023 A label for the docathon in H1 2023 intro medium

Comments

@sadra-barikbin
Copy link

sadra-barikbin commented Dec 6, 2021 •
edited by pytorch-bot bot
Loading

tutorials/beginner_source/nn_tutorial.py

Line 776 in 796013c

batches = iter(self.dl)

There is no need to call iter in this line and that is misleading. Internally, by calling iter an _BaseDataLoaderIter instance is returned. Then in the for loop, again iter is called by the interpreter and the same instance is returned. So there is no need to that call.

cc @suraj813
@svekars svekars added the intro label Dec 5, 2022
@svekars svekars added medium docathon-h1-2023 A label for the docathon in H1 2023 labels May 31, 2023
@HemanthSai7
Copy link
Contributor

/assigntome

@HemanthSai7 HemanthSai7 mentioned this issue Jun 1, 2023
Merged
4 tasks
@HemanthSai7
Copy link
Contributor

Whom do I tag in the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HemanthSai7 HemanthSai7

Labels
docathon-h1-2023 A label for the docathon in H1 2023 intro medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize DataLoader iteration in WrappedDataLoader HemanthSai7/tutorials
3 participants
@svekars @sadra-barikbin @HemanthSai7