Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the Reinforcement Learning (DQN) tutorial #2897

Closed
sekyondaMeta opened this issue Jun 4, 2024 · 5 comments · Fixed by #2934
Closed

Test the Reinforcement Learning (DQN) tutorial #2897

sekyondaMeta opened this issue Jun 4, 2024 · 5 comments · Fixed by #2934
Assignees
Labels
docathon-h1-2024 easy rl Issues related to reinforcement learning tutorial, DQN, and so on

Comments

@sekyondaMeta
Copy link
Contributor

sekyondaMeta commented Jun 4, 2024

Test the following tutorial:
https://pytorch.org/tutorials/intermediate/reinforcement_q_learning.html
Follow these steps:

  1. Fork the pytorch/tutorials repo.
  2. Switch to a new branch.
  3. Run the tutorial as a python script:
python3 <path-to-tutorial>
  1. Save the output into a .txt file. Did you see any errors? Add them to the output.
  2. Run the tutorial in the Google Colab and save the outputs into a .txt file. Did you see any issues? Take screenshots of the issues.
  3. Did the tutorial make sense? Can you suggest any improvements? Past all the outputs, screenshots, and suggestions for improvements in the issue and ping one of the reviewers. If your suggestion is approved, please submit a PR with the fix.

cc @vmoens @nairbv @svekars @kit1980 @brycebortree

@alperenunlu
Copy link
Contributor

/assigntome

@alperenunlu
Copy link
Contributor

/assigntome

@alperenunlu
Copy link
Contributor

alperenunlu commented Jun 10, 2024

MacOS output:

Complete
Figure_1

Colab output:

Complete
Unknown

Suggestions:

cc: @svekars

@svekars svekars added the rl Issues related to reinforcement learning tutorial, DQN, and so on label Jun 12, 2024
@svekars
Copy link
Contributor

svekars commented Jun 12, 2024

@vmoens - can you comment on whether these suggestions make sense?

@vmoens
Copy link
Contributor

vmoens commented Jun 14, 2024

This is what you get if you run it for longer (from the tuto)
image
So I'm not worried by these learning curves.

We usually run into issues when using MPS but if it works I'm open to have that option in the tuto!

We should definitely cite the paper!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docathon-h1-2024 easy rl Issues related to reinforcement learning tutorial, DQN, and so on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants