Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the Running the Tutorial Code tutorial #2901

Closed
sekyondaMeta opened this issue Jun 4, 2024 · 7 comments · Fixed by #2937
Closed

Test the Running the Tutorial Code tutorial #2901

sekyondaMeta opened this issue Jun 4, 2024 · 7 comments · Fixed by #2937
Assignees
Labels
core Tutorials of any level of difficulty related to the core pytorch functionality docathon-h1-2024 easy

Comments

@sekyondaMeta
Copy link
Contributor

sekyondaMeta commented Jun 4, 2024

Test the following tutorial:
https://pytorch.org/tutorials/beginner/introyt.html
Follow these steps:

  1. Fork the pytorch/tutorials repo.
  2. Switch to a new branch.
  3. Run the tutorial as a python script:
python3 <path-to-tutorial>
  1. Save the output into a .txt file. Did you see any errors? Add them to the output.
  2. Run the tutorial in the Google Colab and save the outputs into a .txt file. Did you see any issues? Take screenshots of the issues.
  3. Did the tutorial make sense? Can you suggest any improvements? Past all the outputs, screenshots, and suggestions for improvements in the issue and ping one of the reviewers. If your suggestion is approved, please submit a PR with the fix.

cc @albanD @svekars @kit1980 @brycebortree

@abhi2596
Copy link

abhi2596 commented Jun 4, 2024

/assigntome

@sekyondaMeta
Copy link
Contributor Author

@abhi2596 Do you have an update on this? If you are not able to work on this, we can re-assign someone to it.

@abhi2596
Copy link

abhi2596 commented Jun 12, 2024

I started working on this, I ran first two tutorials in google colab and did not notice any errors.

@zeshengzong
Copy link
Contributor

@svekars
Hello, I found in the pytorch dtype doc(link in below) is torch.bfloat16, but in tutorial istorch.bfloat , this might be mislead user to created dtype=torch.bfloat and get an error, might be better to make improvements:

  • change tutorial consistent with doc, both dtype=torch.bfloat16
  • and also suggest to add a link reference to dtype doc, which make users easier to find the specific explanation of dtype.
image

If these changes looks good, I would like to submit a PR, thanks! 😆

tutorial link: https://pytorch.org/tutorials/beginner/introyt/tensors_deeper_tutorial.html
doc link: https://pytorch.org/docs/stable/tensor_attributes.html#torch.dtype

tutorial is torch.bfloat
image

Got error when try to create
image

Should be dtype=torch.bfloat16
image

@abhi2596 abhi2596 removed their assignment Jun 13, 2024
@svekars svekars added the core Tutorials of any level of difficulty related to the core pytorch functionality label Jun 14, 2024
@svekars svekars assigned abhi2596 and unassigned subramen and albanD Jun 14, 2024
@svekars
Copy link
Contributor

svekars commented Jun 14, 2024

@abhi2596 I like the idea of adding a link to the dtype doc - feel free to submit a PR on this. You can remove the list from here - just add a link to the dtype doc

@abhi2596
Copy link

Hi @svekars,That wasn't my idea; it was @hippocookie's idea. I think he has a PR, so I unassigned myself from the task.

@zeshengzong
Copy link
Contributor

@abhi2596 Thanks 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Tutorials of any level of difficulty related to the core pytorch functionality docathon-h1-2024 easy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants