Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Accelerating PyTorch Transformers by replacing nn.Transformer with Nested Tensors and torch.compile() #3176

Open
AdrianOrenstein opened this issue Dec 6, 2024 · 1 comment
Assignees
Labels

Comments

@AdrianOrenstein
Copy link

AdrianOrenstein commented Dec 6, 2024

Add Link

https://pytorch.org/tutorials/intermediate/transformer_building_blocks.html

Describe the bug

Unfinished sentence in the tutorial:

"Thanks to this PR this is no longer the case. Instead, fully masked rows in scaled_dot_product_attention [missing text]. For cases where nn.MHA does not employ the “fast-path”, this will also apply."

Describe your environment

Brave Browser.

@mikaylagawarecki
Copy link
Contributor

Thanks for catching this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants