Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the note of needing scipy in GoogleNet and Inception #4919

Closed
oke-aditya opened this issue Nov 11, 2021 · 5 comments · Fixed by #4922
Closed

Remove the note of needing scipy in GoogleNet and Inception #4919

oke-aditya opened this issue Nov 11, 2021 · 5 comments · Fixed by #4922

Comments

@oke-aditya
Copy link
Contributor

📚 The doc issue

I think after merging #4256 We should update the docs to indicate scipy isn't needed. As I see in the code base models/googlenet.py and models/inception.py we use torch and not scipy.

Suggest a potential alternative/fix

Fix the note by removing the line regarding scipy.

Inception
https://github.com/pytorch/vision/blob/main/docs/source/models.rst#inception-v3

GoogleNet
https://github.com/pytorch/vision/blob/main/docs/source/models.rst#googlenet

It's a good first issue. Probably some new contributor would be interested.

@Carlosbogo
Copy link
Contributor

Hi, I would be interested in helping with this

@datumbox
Copy link
Contributor

@Carlosbogo there was already a PR what wasn't linked to this ticket by a different user. :(

@Carlosbogo
Copy link
Contributor

Oh no problem then, I'm glad that it got solved.

@WathikAhmed
Copy link

Solved? close issue.

@oke-aditya
Copy link
Contributor Author

Not yet. Once the linked PR is merged maintainers will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants