Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMG_EXTENSIONS lost "." for webp #835

Closed
xialeizhou opened this issue Apr 5, 2019 · 9 comments
Closed

IMG_EXTENSIONS lost "." for webp #835

xialeizhou opened this issue Apr 5, 2019 · 9 comments

Comments

@xialeizhou
Copy link

#  torchvision/datasets/folder.py
IMG_EXTENSIONS = ('.jpg', '.jpeg', '.png', '.ppm', '.bmp', '.pgm', '.tif', '.tiff', 'webp')

webp =>.webp

@surgan12
Copy link
Contributor

surgan12 commented Apr 5, 2019

@xialeizhou Thanks for reporting.
Could you send a PR fixing this.

@Ashok93
Copy link
Contributor

Ashok93 commented Apr 5, 2019

Can I take this up and send a PR?

@surgan12
Copy link
Contributor

surgan12 commented Apr 5, 2019

@Ashok93 Sure Why not !

@Ashok93
Copy link
Contributor

Ashok93 commented Apr 5, 2019

@surgan12 Thanks! Pull request ref #836

@fmassa
Copy link
Member

fmassa commented Apr 5, 2019

Fixed via #836
Thanks @Ashok93

@fmassa fmassa closed this as completed Apr 5, 2019
@surgan12
Copy link
Contributor

surgan12 commented Apr 5, 2019

@Ashok93 it also has some lint errors .
Can you try and fix them too. ?

@Ashok93
Copy link
Contributor

Ashok93 commented Apr 5, 2019

@surgan12 Can you specify the linting issue? I cannot find it and it seems okay.

@fmassa
Copy link
Member

fmassa commented Apr 5, 2019

@surgan12 the linting issues are on my side, no need to fix them now

@fmassa
Copy link
Member

fmassa commented Apr 5, 2019

I'll be fixing the linting issues now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants