Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build CUDA-11 Windows cmake using C++17 #4945

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Build CUDA-11 Windows cmake using C++17 #4945

merged 1 commit into from
Nov 16, 2021

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Nov 16, 2021 •
edited
Loading

Fixes compilation error such as(full log):

    1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\xutility(1309): error : expected a "(" [C:\Users\circleci\project\cpp_build\torchvision.vcxproj]
                   detected during instantiation of "void std::_Adl_verify_range(const _Iter &, const _Sentinel &) [with _Iter=const char *, _Sentinel=const char *]" 
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\xlocale(1990): here

For more details about CUDA-11.x and VC++ behavior see for example: actions/runner-images#3485

@facebook-github-bot
Copy link

facebook-github-bot commented Nov 16, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 682aa05 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@malfet malfet mentioned this pull request Nov 16, 2021
Merged
datumbox
datumbox approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@malfet malfet merged commit 3b20242 into main Nov 16, 2021
@malfet malfet deleted the malfet/fix-win-cmake-cuda-11-builds branch November 16, 2021 17:35
@github-actions
Copy link

Hey @malfet!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@datumbox datumbox mentioned this pull request Nov 17, 2021
Merged
facebook-github-bot pushed a commit that referenced this pull request Nov 17, 2021
@kazhang @facebook-github-bot
[fbsync] Build CUDA-11 Windows cmake using C++17 (#4945)
da3bcbe 
Reviewed By: datumbox

Differential Revision: D32470477

fbshipit-source-id: d005f1bf87ebf50f23a814eaa99b9474f82a7087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
ciflow/default cla signed enhancement module: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malfet @facebook-github-bot @datumbox