-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmarks/torchbench_model: some benchmarks fail to load and kill experiment_runner's main process #6207
Comments
@cota thanks for addressing this, can we close this issue now? |
We're working around this issue by temporarily disabling the affected benchmarks. But AFAICT this is still an issue. If you want we can close it -- I won't be working on this in the near future. |
I'm only running
|
🐛 Bug
In
dfcf306e7 Apply precision config env vars in the root process.
(#6152)we started running load_benchmark() from experiment_runner's
main process. Unfortunately, load_benchmark() for
some models does exit the calling process.
This results in experiment_runner exiting prematurely.
To Reproduce
Try to run under XLA any of the benchmarks added to the deny list in #6199. For example:
Note:
pytorch_CycleGAN_and_pix2pix
also fails early under inductor.Expected behavior
The above should print a
0
exit code regardless of whether the benchmark fails to run or not. However, it prints2
.Environment
The text was updated successfully, but these errors were encountered: