Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the verifier on Torchbench in the Nigthly CI. #8070

Open
ysiraichi opened this issue Sep 25, 2024 · 2 comments
Open

Run the verifier on Torchbench in the Nigthly CI. #8070

ysiraichi opened this issue Sep 25, 2024 · 2 comments

Comments

@ysiraichi
Copy link
Collaborator

As far as I understand it, we have a nightly CI that runs Torchbench daily. I believe it would be beneficial to also run the verifier (as documented here), so as to catch, as early as, possible regressions.

cc @miladm @zpcore @JackCaoG

@zpcore
Copy link
Collaborator

zpcore commented Sep 25, 2024

Currently the CI script runs

python experiment_runner.py --suite-name=torchbench --accelerator=cuda --progress-bar --xla=PJRT --xla=None --dynamo=None --dynamo=openxla --dynamo=inductor

Hi @ysiraichi , correct me if I am wrong. Looks like we need to run the same command again with --verify flag to get the verification code for each configufation. Apart from that, we also need to add the field verification_code and verification_mean_rel_error etc in result_analyzer.py.

We also need to update our looker studio UI to display the verification result. I can take those action items later.

@ysiraichi
Copy link
Collaborator Author

That's about it. I don't think there's a verification_mean_rel_error anymore, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants