Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed fees if not present #128

Merged
merged 2 commits into from
Oct 18, 2024
Merged

fixed fees if not present #128

merged 2 commits into from
Oct 18, 2024

Conversation

BjBe82
Copy link
Contributor

@BjBe82 BjBe82 commented Oct 14, 2024

see Issue: #127

@BjBe82 BjBe82 mentioned this pull request Oct 14, 2024
Closed
pinzutu
pinzutu suggested changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@pinzutu pinzutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! For the sake of consistently formatting feeless transactions with an empty csv fees field instead of sometimes using "0.0", it is preferable for the default get value to be None.

@BjBe82
Copy link
Contributor Author

BjBe82 commented Oct 15, 2024

Changed the default value to None and checked this again with my events.

@Katzmann1983 Katzmann1983 merged commit 2ac0191 into pytr-org:master Oct 18, 2024
@BjBe82 BjBe82 deleted the Issue-127-error-parsing-fees branch October 19, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinzutu pinzutu pinzutu requested changes

@Felixoid Felixoid Felixoid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BjBe82 @Felixoid @pinzutu @Katzmann1983