Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing handling of card refunds for portfolio performance csv export #87

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

timo-keller
Copy link
Contributor

Currently, refunds on Visa credit card transactions are not included in the Portfolio Performance CSV.

[ { "id": "bc663404-36f7-5027-b0a6-ca9f856b7acb", "timestamp": "2024-06-28T06:36:08.258+0000", "title": "Amazon", "icon": "logos/merchant-9c4e270f-84f4-4c45-9bfe-026d66d148b1/v2", "badge": null, "subtitle": null, "amount": { "currency": "EUR", "value": 9.99, "fractionDigits": 2 }, "subAmount": null, "status": "EXECUTED", "action": { "type": "timelineDetail", "payload": "bc663404-36f7-5027-b0a6-ca9f856b7acb" }, "eventType": "card_refund", "source": "timelineTransaction", "details": { "id": "bc663404-36f7-5027-b0a6-ca9f856b7acb", "sections": [ { "title": "Du hast 9,99 € erhalten", "data": { "icon": "logos/merchant-9c4e270f-84f4-4c45-9bfe-026d66d148b1/v2", "subtitleText": null, "timestamp": "2024-06-28T06:36:08.258+0000", "status": "executed" }, "action": null, "type": "header" }, { "title": "Übersicht", "data": [ { "title": "Status", "detail": { "text": "Fertig", "functionalStyle": "EXECUTED", "type": "status" }, "style": "plain" }, { "title": "Zahlungsart", "detail": { "text": "Rückerstattung", "trend": null, "action": null, "type": "text" }, "style": "plain" }, { "title": "Händler", "detail": { "text": "Amazon", "trend": null, "action": null, "type": "text" }, "style": "plain" } ], "action": null, "type": "table" } ] } } ]

This pull request implements the handling for these timeline entries.

@timo-keller timo-keller changed the title added missing handling of card refunds to portfolio performance csv Added missing handling of card refunds for portfolio performance csv export Jul 3, 2024
@Katzmann1983 Katzmann1983 merged commit 5e5106b into pytr-org:master Jul 4, 2024
@Katzmann1983
Copy link
Collaborator

Looks good

@Katzmann1983
Copy link
Collaborator

Just checked and the following event types are currently not handled either:
11:15:24 unhandled event typte TRADE_INVOICE
11:15:24 unhandled event typte benefits_saveback_execution
11:15:24 unhandled event typte ssp_corporate_action_invoice_cash
11:15:24 unhandled event typte ORDER_EXECUTED
11:15:24 unhandled event typte CREDIT
11:15:24 unhandled event typte SAVINGS_PLAN_EXECUTED
11:15:24 unhandled event typte card_failed_transaction
In case any of these are relevant for Portfolio Permonace, it would be great to add them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants