Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate why depth loss has such a big performance impact on 3D anim mode #171

Open
dmarx opened this issue May 25, 2022 · 2 comments
Open

Comments

@dmarx
Copy link
Member

dmarx commented May 25, 2022

presumably we're already computing depth for the 3D warps: we should get the loss for free. I suspect we are unnecessarily re-estimating depth here

@dmarx dmarx added enhancement New feature or request Experiment labels May 25, 2022
@dmarx
Copy link
Member Author

dmarx commented May 25, 2022

is the flow being applied to the depth field? that might explain it. and if it's not, it should be.

maybe this is a use case for one of those representations that carries depth information in addition to visual?

@dmarx
Copy link
Member Author

dmarx commented May 25, 2022

when we sample to backfill occluded pixels (which also... should we maybe just optimize these directly? is sampling just for the init?), are we taking the depth map into consideration? I'm guessing we're not, which probably causes a lot of the weird shape pathologies, where it'll look like a face or something, but then it'll suddenly flatten out onto one edge and smear into like a face generator (like a cellular automata slider generator).

@dmarx dmarx removed the enhancement New feature or request label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant