Add MPL 3.1 deprecations to rcparam context manager #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry you had to go through discovering this, I remember being confused by this for a very long time. |
philippjfr
force-pushed
the
rcparam_deprecations
branch
from
f4a69c9
to
758857e
Compare
|
Didn't know you were ready to merge yet. I recall some unit tests were failing on grounds of plot sizes or something, is that resolved? Hadn't had time to look into that yet. |
Yes, sorry, should have warned. I fixed that separately. |
|
Perfect, no problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #3745 and thereby fixes #3766
Source: https://matplotlib.org/3.1.0/api/api_changes.html
This confused me for a bit, but it turned out that the deprecated arguments were simply carried over from
matplotlib.rcParamswhere they then threw the warnings.