-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New diagonal_operation-Parameter for the gridmatrix operation #1027
New diagonal_operation-Parameter for the gridmatrix operation #1027
Conversation
Sorry I've been so slow in reviewing this, I'll get to it over the weekend. |
holoviews/operation/element.py
Outdated
bin_range = ranges.get(d1.name, element.range(d1)) | ||
el = p.diagonal_operation(element, | ||
dimension=d1.name, | ||
bin_range=bin_range) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid this won't behave very well unless axiswise normalization is enabled here.
Sorry for the long delay, this looks fine, except one small comment. If you don't think you'll have the time I'm happy to merge anyway and apply the change myself. |
Your comment should be fixed now. |
Perfect thanks! I'm actually going to clean up the histogram operation a bit to remove the |
Unless you feel like writing some simple tests that is? |
I'm not sure on how to test this. As I cannot find tests for the other operations, can you point to something similar? |
You're right, it appears operations are not currently tested at all! I'd create a new file called |
Could you rebase the PR, I'll get this merged and add unit tests separately. |
Sorry I did not find the time to look into the tests yet. I will do the rebase tomorrow! |
@philippjfr I rebased with 144b7e2 in mind. |
Sorry this has stalled so long, I think tests are still failing because framewise normalization is not enabled. I'll fix the tests in a separate PR. |
Instead of being restricted to a plot type along the diagonal of a gridmatrix-operation, this pull request also allows the specification of an operation. The main reasoning for this is that it is now possible to change parameters like the number of bins in a diagonal histogram:
I think in its current state, this PR is not ready however, since there are a few open questions:
diagonal_type
remain?chart_operation
parameter?When the semantics are decided, I can also add a few tests. I will probably need a few hints however on how to test this.