-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define length on Annotation Elements #1133
Conversation
A length of 1 seems reasonable. If |
I just added a general |
Happy to merge once the tests pass. |
Hmm, so this is problematic, turns out something is actively looking for the |
My initial reaction is this could be due to testing of the boolean value of elements or pretty printing... |
3fe9d39
to
ead8102
Compare
ead8102
to
c47e842
Compare
@jlstevens I think this is the correct fix now, I'll still try to reproduce the original bug so I can add a unit test. |
fcf1dc9
to
29d528b
Compare
I also just found out that cloning of |
45be77a
to
67397ae
Compare
67397ae
to
ae3c972
Compare
Other than one transient error, tests are passing. Ready to merge? |
Yes, I think it's ready now. |
Tests have all passed now. Merging. |
Defining a length is part of the core API and I have run into failures which I cannot reproduce right now because the annotations do not support it. Setting length 1 is consistent with how their
dimension_values
methods work, which return length 1 arrays.Edit: I threw a bug fix for a small bug on the Arrow Annotation