Remove bokeh matplotlib compatibility #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
deprecate_bokeh_mpl
branch
from
5639fe1
to
28df1cb
Compare
|
Looks good. I share your worries about backwards compatibility but As we are removing functionality, I do think we definitely ought to get the corresponding statistical elements into 2.0. This is something we should mention in the CHANGELOG to try and re-assure anyone using these things that this functionality will be restored in a better way soon. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #1218 this removes the BokehMPLWrapper plot class and support for Distribution, Bivariate, and TimeSeries Elements. I was initially hesitant to remove this entirely in 1.7 but with the amount of warnings these currently generate and other restrictions on these plot types, I think just removing them is the correct thing to do. Hopefully we can readd Distribution and Bivariate support in 2.0 as part of the statistical elements module (#1200).