Bokeh widgets editable #1247
Merged
Bokeh widgets editable #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
bokeh_widgets_editable
branch
from
203952c
to
c4f51fc
Compare
|
Ready to review/merge. |
jlstevens
reviewed
Apr 7, 2017
holoviews/plotting/bokeh/widgets.py
Outdated
| css = param.String(default=None, precedence=-1, doc=""" | ||
| Defines the local CSS file to be loaded for this widget.""") | ||
| editable = param.Boolean(default=False, doc=""" | ||
| Whether the slider text fields should be editable.""") |
There was a problem hiding this comment.
Should mention the the reason it is disabled by default. It sounds useful, so there is a reason we want it off by default...
|
Fairly short PR and other than updating the docstring, it looks good. |
philippjfr
force-pushed
the
bokeh_widgets_editable
branch
from
c4f51fc
to
a8afcfa
Compare
|
Tests passing. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an editable option, which is False by default to improve the look of the widgets, but because that disables support for enabling text input on sliders, can be set to True if needed.