Docs and minor code fixes #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordansamuels
pushed a commit
to jordansamuels/holoviews
that referenced
this pull request
Jul 27, 2017
* Complements holoviz#1759 * Execute `git grep -lE '\)\((style|plot|norm)=' -- examples | xargs perl -pi -e 's/\)\((style|plot|norm)=/).opts($1=/g'` * Spot check notebooks
|
@ea42gh @jordansamuels Thank you both - this is really helpful! I wasn't looking forward to updating all these references myself but you two seem to have sorted it out! Skimming the diff here, the changes all look right but I'll have another pass before merging. This PR should probably be merged first and then I can review and merge @jordansamuels PR. |
|
Yup, all looks good! Merging. |
jordansamuels
pushed a commit
to jordansamuels/holoviews
that referenced
this pull request
Jul 27, 2017
* __call__ to .opts() mods * __call__ to .opts() mods * __call__ to .opts() mods
jordansamuels
pushed a commit
to jordansamuels/holoviews
that referenced
this pull request
Jul 27, 2017
* Complements holoviz#1759 * Execute `git grep -lE '\)\((style|plot|norm)=' -- examples | xargs perl -pi -e 's/\)\((style|plot|norm)=/).opts($1=/g'` * Spot check notebooks
Merged
jlstevens
pushed a commit
that referenced
this pull request
Jul 27, 2017
* Replace (...) with .opts() * Complements #1759 * Execute `git grep -lE '\)\((style|plot|norm)=' -- examples | xargs perl -pi -e 's/\)\((style|plot|norm)=/).opts($1=/g'` * Spot check notebooks * A few more cases thanks to @ea42gh * Manually search `git grep ')(' -- examples | grep -vE '.{255}' * Fix cases by hand `
jsignell
pushed a commit
to holoviz-topics/examples
that referenced
this pull request
May 6, 2019
* Replace (...) with .opts() * Complements holoviz/holoviews#1759 * Execute `git grep -lE '\)\((style|plot|norm)=' -- examples | xargs perl -pi -e 's/\)\((style|plot|norm)=/).opts($1=/g'` * Spot check notebooks * A few more cases thanks to @ea42gh * Manually search `git grep ')(' -- examples | grep -vE '.{255}' * Fix cases by hand `
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hope this works:
changed
__call__to .opts() in 3 files