Add opts in doc 2 #1763
Merged
Add opts in doc 2 #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 27, 2017 08:48
* Complements holoviz#1759 * Execute `git grep -lE '\)\((style|plot|norm)=' -- examples | xargs perl -pi -e 's/\)\((style|plot|norm)=/).opts($1=/g'` * Spot check notebooks
* Manually search `git grep ')(' -- examples | grep -vE '.{255}'
* Fix cases by hand
`
|
Having skimmed the diff, all the changes look correct to me. As the tests are green, I think it is better to merge sooner than later. I'm sure there will be other places that @jordansamuels Thanks again for this PR! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaner version of #1760, which inadvertently picked up #1759 during a rebase.