Decode bytes in bokeh plots #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
bokeh_bytes
branch
6 times, most recently
from
ede64f1
to
da4c868
Compare
philippjfr
force-pushed
the
bokeh_bytes
branch
from
da4c868
to
eb16b2d
Compare
|
Ready to review/merge. |
|
Looks good though I think this issue needs more thorough investigation before we can be confident that we have the most general/robust fix. If you file an issue as a reminder to do that, I'm happy to merge this as a fix (even if it only a partial fix, it will handle more inputs that always erroring, as you say). |
|
Thanks for filing the issue. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to decode bytes types passed to bokeh plots. As part of the Intake project I'm building a HoloViews based plotting API, many of the data sources in this project includes
bytestypes even in Python3 which currently cannot be serialized by bokeh causing errors. In this API its not really practical to convert the bytes types to strings, so it would be helpful if we could just assume utf-8 encoding (which will be most common). This will of course not always work but based on my testing it works in most cases, which is better than the current case where it works in no cases.